R: Remove redundant checks

rsconcept/frontend/src/components/RefsInput/RefsInput.tsx

@@ -63,15 +63,16 @@ interface RefsInputInputProps
     | 'onBlur'
     | 'placeholder'
   > {
-  label?: string;
-  onChange?: (newValue: string) => void;
-  schema?: IRSForm;
-  onOpenEdit?: (cstID: ConstituentaID) => void;
-  disabled?: boolean;
-
-  initialValue?: string;
   value?: string;
   resolved?: string;
+  onChange?: (newValue: string) => void;
+
+  schema: IRSForm;
+  onOpenEdit?: (cstID: ConstituentaID) => void;
+
+  label?: string;
+  disabled?: boolean;
+  initialValue?: string;
 }
 
 const RefsInput = forwardRef<ReactCodeMirrorRef, RefsInputInputProps>(
@@ -130,8 +131,8 @@ const RefsInput = forwardRef<ReactCodeMirrorRef, RefsInputInputProps>(
       EditorView.lineWrapping,
       EditorView.contentAttributes.of({ spellcheck: 'true' }),
       NaturalLanguage,
-      ...(!schema || !onOpenEdit ? [] : [refsNavigation(schema, onOpenEdit)]),
+      ...(!onOpenEdit ? [] : [refsNavigation(schema, onOpenEdit)]),
-      ...(schema ? [refsHoverTooltip(schema, onOpenEdit !== undefined)] : [])
+      refsHoverTooltip(schema, onOpenEdit !== undefined)
     ];
 
     function handleChange(newValue: string) {
@@ -149,7 +150,7 @@ const RefsInput = forwardRef<ReactCodeMirrorRef, RefsInputInputProps>(
     }
 
     function handleInput(event: React.KeyboardEvent<HTMLDivElement>) {
-      if (!thisRef.current?.view || !schema) {
+      if (!thisRef.current?.view) {
         event.preventDefault();
         event.stopPropagation();
         return;

rsconcept/frontend/src/models/rsformAPI.ts

@@ -242,7 +242,7 @@ export function getDefinitionPrefix(cst: IConstituenta): string {
  */
 export function generateAlias(type: CstType, schema: IRSForm, takenAliases: string[] = []): string {
   const prefix = getCstTypePrefix(type);
-  if (!schema.items || schema.items.length <= 0) {
+  if (schema.items.length <= 0) {
     return `${prefix}1`;
   }
   let index = schema.items.reduce((prev, cst, index) => {

rsconcept/frontend/src/pages/OssPage/EditorOssCard/EditorOssCard.tsx

@@ -49,7 +49,7 @@ function EditorOssCard() {
           <EditorLibraryItem controller={controller} />
         </FlexColumn>
 
-        {controller.schema ? <OssStats stats={controller.schema.stats} /> : null}
+        <OssStats stats={controller.schema.stats} />
       </div>
     </>
   );

rsconcept/frontend/src/pages/OssPage/EditorOssCard/FormOSS.tsx

@@ -70,9 +70,6 @@ function FormOSS({ id }: FormOSSProps) {
     if (event) {
       event.preventDefault();
     }
-    if (!schema) {
-      return;
-    }
     const data: IUpdateLibraryItemDTO = {
       id: schema.id,
       item_type: LibraryItemType.RSFORM,

rsconcept/frontend/src/pages/OssPage/OssEditContext.tsx

@@ -120,9 +120,6 @@ export const OssEditState = ({ itemID, children }: React.PropsWithChildren<OssEd
   );
 
   function navigateTab(tab: OssTabID) {
-    if (!schema) {
-      return;
-    }
     const url = urls.oss_props({
       id: schema.id,
       tab: tab

rsconcept/frontend/src/pages/RSFormPage/EditorRSFormCard/EditorRSFormCard.tsx

@@ -48,7 +48,7 @@ function EditorRSFormCard() {
           <EditorLibraryItem controller={controller} />
         </FlexColumn>
 
-        {controller.schema ? <RSFormStats stats={controller.schema.stats} isArchive={controller.isArchive} /> : null}
+        <RSFormStats stats={controller.schema.stats} isArchive={controller.isArchive} />
       </div>
     </>
   );

rsconcept/frontend/src/pages/RSFormPage/EditorRSFormCard/FormRSForm.tsx

@@ -80,9 +80,6 @@ function FormRSForm({ id }: FormRSFormProps) {
     if (event) {
       event.preventDefault();
     }
-    if (!schema) {
-      return;
-    }
     const data: IUpdateLibraryItemDTO = {
       id: schema.id,
       item_type: LibraryItemType.RSFORM,

rsconcept/frontend/src/pages/RSFormPage/RSEditContext.tsx

@@ -139,9 +139,6 @@ export const RSEditState = ({
   }
 
   function navigateRSForm({ tab, activeID }: { tab: RSTabID; activeID?: ConstituentaID }) {
-    if (!schema) {
-      return;
-    }
     const data = {
       id: schema.id,
       tab: tab,
@@ -170,7 +167,7 @@ export const RSEditState = ({
   }
 
   function deleteSchema() {
-    if (!schema || !window.confirm(prompts.deleteLibraryItem)) {
+    if (!window.confirm(prompts.deleteLibraryItem)) {
       return;
     }
     const ossID = schema.oss.length > 0 ? schema.oss[0].id : undefined;
@@ -227,7 +224,7 @@ export const RSEditState = ({
   }
 
   function moveUp() {
-    if (!schema.items || selected.length === 0) {
+    if (selected.length === 0) {
       return;
     }
     const currentIndex = schema.items.reduce((prev, cst, index) => {
@@ -249,7 +246,7 @@ export const RSEditState = ({
   }
 
   function moveDown() {
-    if (!schema.items || selected.length === 0) {
+    if (selected.length === 0) {
       return;
     }
     let count = 0;