From f1bdb70a761abac4f619af5a9c031cf8a639f099 Mon Sep 17 00:00:00 2001
From: Ivan <8611739+IRBorisov@users.noreply.github.com>
Date: Wed, 5 Feb 2025 12:03:54 +0300
Subject: [PATCH] B: Fix contextmenu animations

---
 .../EditorOssGraph/NodeContextMenu.tsx        | 58 +++++++++----------
 .../pages/OssPage/EditorOssGraph/OssFlow.tsx  |  7 ++-
 2 files changed, 31 insertions(+), 34 deletions(-)

diff --git a/rsconcept/frontend/src/pages/OssPage/EditorOssGraph/NodeContextMenu.tsx b/rsconcept/frontend/src/pages/OssPage/EditorOssGraph/NodeContextMenu.tsx
index 078dc5f2..719c2a67 100644
--- a/rsconcept/frontend/src/pages/OssPage/EditorOssGraph/NodeContextMenu.tsx
+++ b/rsconcept/frontend/src/pages/OssPage/EditorOssGraph/NodeContextMenu.tsx
@@ -1,6 +1,6 @@
 'use client';
 
-import { useEffect, useRef, useState } from 'react';
+import { useRef } from 'react';
 
 import { useMutatingOss } from '@/backend/oss/useMutatingOss';
 import {
@@ -22,12 +22,13 @@ import { prepareTooltip } from '@/utils/labels';
 import { useOssEdit } from '../OssEditContext';
 
 export interface ContextMenuData {
-  operation: IOperation;
+  operation?: IOperation;
   cursorX: number;
   cursorY: number;
 }
 
 interface NodeContextMenuProps extends ContextMenuData {
+  isOpen: boolean;
   onHide: () => void;
   onDelete: (target: OperationID) => void;
   onCreateInput: (target: OperationID) => void;
@@ -38,6 +39,7 @@ interface NodeContextMenuProps extends ContextMenuData {
 }
 
 function NodeContextMenu({
+  isOpen,
   operation,
   cursorX,
   cursorY,
@@ -52,10 +54,9 @@ function NodeContextMenu({
   const controller = useOssEdit();
   const isProcessing = useMutatingOss();
 
-  const [isOpen, setIsOpen] = useState(false);
   const ref = useRef<HTMLDivElement>(null);
   const readyForSynthesis = (() => {
-    if (operation.operation_type !== OperationType.SYNTHESIS) {
+    if (operation?.operation_type !== OperationType.SYNTHESIS) {
       return false;
     }
     if (operation.result) {
@@ -75,47 +76,40 @@ function NodeContextMenu({
     return true;
   })();
 
-  function handleHide() {
-    setIsOpen(false);
-    onHide();
-  }
-
-  useClickedOutside(isOpen, ref, handleHide);
-
-  useEffect(() => setIsOpen(true), []);
+  useClickedOutside(isOpen, ref, onHide);
 
   function handleOpenSchema() {
-    controller.navigateOperationSchema(operation.id);
+    if (operation) controller.navigateOperationSchema(operation.id);
   }
 
   function handleEditSchema() {
-    handleHide();
-    onEditSchema(operation.id);
+    onHide();
+    if (operation) onEditSchema(operation.id);
   }
 
   function handleEditOperation() {
-    handleHide();
-    onEditOperation(operation.id);
+    onHide();
+    if (operation) onEditOperation(operation.id);
   }
 
   function handleDeleteOperation() {
-    handleHide();
-    onDelete(operation.id);
+    onHide();
+    if (operation) onDelete(operation.id);
   }
 
   function handleCreateSchema() {
-    handleHide();
-    onCreateInput(operation.id);
+    onHide();
+    if (operation) onCreateInput(operation.id);
   }
 
   function handleRunSynthesis() {
-    handleHide();
-    onExecuteOperation(operation.id);
+    onHide();
+    if (operation) onExecuteOperation(operation.id);
   }
 
   function handleRelocateConstituents() {
-    handleHide();
-    onRelocateConstituents(operation.id);
+    onHide();
+    if (operation) onRelocateConstituents(operation.id);
   }
 
   return (
@@ -133,7 +127,7 @@ function NodeContextMenu({
           onClick={handleEditOperation}
         />
 
-        {operation.result ? (
+        {operation?.result ? (
           <DropdownButton
             text='Открыть схему'
             titleHtml={prepareTooltip('Открыть привязанную КС', 'Двойной клик')}
@@ -142,7 +136,7 @@ function NodeContextMenu({
             onClick={handleOpenSchema}
           />
         ) : null}
-        {controller.isMutable && !operation.result && operation.operation_type === OperationType.INPUT ? (
+        {controller.isMutable && !operation?.result && operation?.operation_type === OperationType.INPUT ? (
           <DropdownButton
             text='Создать схему'
             title='Создать пустую схему для загрузки'
@@ -151,16 +145,16 @@ function NodeContextMenu({
             onClick={handleCreateSchema}
           />
         ) : null}
-        {controller.isMutable && operation.operation_type === OperationType.INPUT ? (
+        {controller.isMutable && operation?.operation_type === OperationType.INPUT ? (
           <DropdownButton
-            text={!operation.result ? 'Загрузить схему' : 'Изменить схему'}
+            text={!operation?.result ? 'Загрузить схему' : 'Изменить схему'}
             title='Выбрать схему для загрузки'
             icon={<IconConnect size='1rem' className='icon-primary' />}
             disabled={isProcessing}
             onClick={handleEditSchema}
           />
         ) : null}
-        {controller.isMutable && !operation.result && operation.operation_type === OperationType.SYNTHESIS ? (
+        {controller.isMutable && !operation?.result && operation?.operation_type === OperationType.SYNTHESIS ? (
           <DropdownButton
             text='Активировать синтез'
             titleHtml={
@@ -174,7 +168,7 @@ function NodeContextMenu({
           />
         ) : null}
 
-        {controller.isMutable && operation.result ? (
+        {controller.isMutable && operation?.result ? (
           <DropdownButton
             text='Конституенты'
             titleHtml='Перенос конституент</br>между схемами'
@@ -187,7 +181,7 @@ function NodeContextMenu({
         <DropdownButton
           text='Удалить операцию'
           icon={<IconDestroy size='1rem' className='icon-red' />}
-          disabled={!controller.isMutable || isProcessing || !controller.canDelete(operation.id)}
+          disabled={!controller.isMutable || isProcessing || !operation || !controller.canDelete(operation.id)}
           onClick={handleDeleteOperation}
         />
       </Dropdown>
diff --git a/rsconcept/frontend/src/pages/OssPage/EditorOssGraph/OssFlow.tsx b/rsconcept/frontend/src/pages/OssPage/EditorOssGraph/OssFlow.tsx
index 922c74e5..c7743549 100644
--- a/rsconcept/frontend/src/pages/OssPage/EditorOssGraph/OssFlow.tsx
+++ b/rsconcept/frontend/src/pages/OssPage/EditorOssGraph/OssFlow.tsx
@@ -63,7 +63,8 @@ function OssFlow() {
   const [nodes, setNodes, onNodesChange] = useNodesState([]);
   const [edges, setEdges, onEdgesChange] = useEdgesState([]);
   const [toggleReset, setToggleReset] = useState(false);
-  const [menuProps, setMenuProps] = useState<ContextMenuData | undefined>(undefined);
+  const [menuProps, setMenuProps] = useState<ContextMenuData>({ operation: undefined, cursorX: 0, cursorY: 0 });
+  const [isContextMenuOpen, setIsContextMenuOpen] = useState(false);
 
   function onSelectionChange({ nodes }: { nodes: Node[] }) {
     const ids = nodes.map(node => Number(node.id));
@@ -243,12 +244,13 @@ function OssFlow() {
       cursorX: event.clientX,
       cursorY: event.clientY
     });
+    setIsContextMenuOpen(true);
     controller.setShowTooltip(false);
   }
 
   function handleContextMenuHide() {
     controller.setShowTooltip(true);
-    setMenuProps(undefined);
+    setIsContextMenuOpen(false);
   }
 
   function handleCanvasClick() {
@@ -308,6 +310,7 @@ function OssFlow() {
       </Overlay>
       {menuProps ? (
         <NodeContextMenu
+          isOpen={isContextMenuOpen}
           onHide={handleContextMenuHide}
           onDelete={handleDeleteOperation}
           onCreateInput={handleInputCreate}