From c35262dbfd3cfbecd04e3e8bc1da2bfeb14ceb35 Mon Sep 17 00:00:00 2001
From: Ivan <8611739+IRBorisov@users.noreply.github.com>
Date: Wed, 11 Sep 2024 13:24:52 +0300
Subject: [PATCH] M: Cleanup todos

---
 TODO.txt                                                  | 8 +++++++-
 rsconcept/backend/apps/library/views/library.py           | 2 --
 rsconcept/backend/apps/oss/models/OperationSchema.py      | 4 +---
 rsconcept/backend/apps/oss/views/oss.py                   | 1 -
 .../frontend/src/components/ui/DataTable/DataTable.tsx    | 1 -
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/TODO.txt b/TODO.txt
index 5aa5fecc..9dd887c8 100644
--- a/TODO.txt
+++ b/TODO.txt
@@ -9,7 +9,9 @@ For more specific TODOs see comments in code
 - Design first user experience
 - Demo sandbox for anonymous users
 
-- User profile: Settings + settings persistency
+- User profile: Settings + settings server persistency
+- Profile pictures
+- Integrate socials and feedback
 - Custom LibraryItem lists
 - Custom user filters and sharing filters
 
@@ -19,6 +21,8 @@ For more specific TODOs see comments in code
 - Focus on codemirror editor when label is clicked (need React 19 ref for clean code solution)
 - Draggable rows in constituents table
 
+- M-graph visualization for typification and RSForm in general
+
 - replace reagraph with react-flow in TermGraph and FormulaGraph
 - Search functionality for Help Manuals
 - Export PDF (Items list, Graph)
@@ -31,6 +35,8 @@ For more specific TODOs see comments in code
 - Content based search in Library
 - Home page (user specific)
 - Private projects. Consider cooperative editing
+- OSS: synthesis table: auto substitution for diamond synthesis
+
 
 [Tech]
 - duplicate syntax parsing and type info calculations to client. Consider moving backend to Nodejs or embedding c++ lib
diff --git a/rsconcept/backend/apps/library/views/library.py b/rsconcept/backend/apps/library/views/library.py
index 916c1bc9..129d1ecb 100644
--- a/rsconcept/backend/apps/library/views/library.py
+++ b/rsconcept/backend/apps/library/views/library.py
@@ -28,8 +28,6 @@ from .. import serializers as s
 class LibraryViewSet(viewsets.ModelViewSet):
     ''' Endpoint: Library operations. '''
     queryset = m.LibraryItem.objects.all()
-    # TODO: consider using .only() for performance
-
     ordering = '-time_update'
 
     def get_serializer_class(self):
diff --git a/rsconcept/backend/apps/oss/models/OperationSchema.py b/rsconcept/backend/apps/oss/models/OperationSchema.py
index 53629eb5..aeed35d6 100644
--- a/rsconcept/backend/apps/oss/models/OperationSchema.py
+++ b/rsconcept/backend/apps/oss/models/OperationSchema.py
@@ -244,7 +244,6 @@ class OperationSchema:
             original = children[sub.original.pk]
             replacement = children[sub.substitution.pk]
             translated_substitutions.append((original, replacement))
-        # TODO: add auto substitutes for diamond
         receiver.substitute(translated_substitutions)
 
         for cst in receiver.constituents().order_by('order'):
@@ -258,6 +257,7 @@ class OperationSchema:
 
         receiver.restore_order()
         receiver.reset_aliases()
+        receiver.resolve_all_text()
 
         if len(self.cache.graph.outputs[operation.pk]) > 0:
             self.after_create_cst(receiver, list(receiver.constituents().order_by('order')))
@@ -366,8 +366,6 @@ class OperationSchema:
         if destination is None:
             return
 
-        # TODO: update substitutions for diamond synthesis (if needed)
-
         self.cache.ensure_loaded()
         new_mapping = self._transform_mapping(mapping, operation, destination)
         alias_mapping = OperationSchema._produce_alias_mapping(new_mapping)
diff --git a/rsconcept/backend/apps/oss/views/oss.py b/rsconcept/backend/apps/oss/views/oss.py
index adc70da8..dc929b60 100644
--- a/rsconcept/backend/apps/oss/views/oss.py
+++ b/rsconcept/backend/apps/oss/views/oss.py
@@ -367,7 +367,6 @@ class OssViewSet(viewsets.GenericViewSet, generics.ListAPIView, generics.Retriev
     @action(detail=False, methods=['post'], url_path='get-predecessor')
     def get_predecessor(self, request: Request) -> HttpResponse:
         ''' Get predecessor. '''
-        # TODO: add tests for this method
         serializer = CstTargetSerializer(data=request.data)
         serializer.is_valid(raise_exception=True)
         cst = cast(Constituenta, serializer.validated_data['target'])
diff --git a/rsconcept/frontend/src/components/ui/DataTable/DataTable.tsx b/rsconcept/frontend/src/components/ui/DataTable/DataTable.tsx
index 52ab309a..bb1e0eb8 100644
--- a/rsconcept/frontend/src/components/ui/DataTable/DataTable.tsx
+++ b/rsconcept/frontend/src/components/ui/DataTable/DataTable.tsx
@@ -127,7 +127,6 @@ function DataTable<TData extends RowData>({
 
   const isEmpty = tableImpl.getRowModel().rows.length === 0;
 
-  // TODO: refactor formula for different font sizes and pagination tools
   const fixedSize = useMemo(() => {
     if (!rows) {
       return undefined;