From 55e09d856ff4e4c5dac5f4ecf3103029860148e2 Mon Sep 17 00:00:00 2001
From: Ivan <8611739+IRBorisov@users.noreply.github.com>
Date: Wed, 28 Aug 2024 23:02:48 +0300
Subject: [PATCH] B: Fix tooltip clipping after cst==null

---
 .../EditorConstituenta/FormConstituenta.tsx   | 190 +++++++++---------
 .../EditorRSExpression/EditorRSExpression.tsx |  15 +-
 .../EditorRSExpression/StatusBar.tsx          |   8 +-
 3 files changed, 106 insertions(+), 107 deletions(-)

diff --git a/rsconcept/frontend/src/pages/RSFormPage/EditorConstituenta/FormConstituenta.tsx b/rsconcept/frontend/src/pages/RSFormPage/EditorConstituenta/FormConstituenta.tsx
index 47a47394..f21e0baf 100644
--- a/rsconcept/frontend/src/pages/RSFormPage/EditorConstituenta/FormConstituenta.tsx
+++ b/rsconcept/frontend/src/pages/RSFormPage/EditorConstituenta/FormConstituenta.tsx
@@ -171,101 +171,103 @@ function FormConstituenta({
             colors='clr-app clr-text-default'
           />
         ) : null}
-        <AnimatePresence>
-          <AnimateFade key='cst_expression_fade' hideContent={!state || (!state?.definition_formal && isElementary)}>
-            <EditorRSExpression
-              id='cst_expression'
-              label={
-                state?.cst_type === CstType.STRUCTURED
-                  ? 'Область определения'
-                  : !!state && isFunctional(state.cst_type)
-                  ? 'Определение функции'
-                  : 'Формальное определение'
-              }
-              placeholder={
-                state?.cst_type !== CstType.STRUCTURED
-                  ? 'Родоструктурное выражение'
-                  : 'Определение множества, которому принадлежат элементы родовой структуры'
-              }
-              value={expression}
-              activeCst={state}
-              disabled={disabled || state?.is_inherited}
-              toggleReset={toggleReset}
-              onChange={newValue => setExpression(newValue)}
-              setTypification={setTypification}
-              onOpenEdit={onOpenEdit}
-            />
-          </AnimateFade>
-          <AnimateFade key='cst_definition_fade' hideContent={!state || (!state?.definition_raw && isElementary)}>
-            <RefsInput
-              id='cst_definition'
-              label='Текстовое определение'
-              placeholder='Текстовая интерпретация формального выражения'
-              minHeight='3.75rem'
-              maxHeight='8rem'
-              schema={schema}
-              onOpenEdit={onOpenEdit}
-              value={textDefinition}
-              initialValue={state?.definition_raw ?? ''}
-              resolved={state?.definition_resolved ?? ''}
-              disabled={disabled}
-              onChange={newValue => setTextDefinition(newValue)}
-            />
-          </AnimateFade>
-          <AnimateFade key='cst_convention_fade' hideContent={!showConvention || !state}>
-            <TextArea
-              id='cst_convention'
-              fitContent
-              className='max-h-[8rem]'
-              spellCheck
-              label={isBasic ? 'Конвенция' : 'Комментарий'}
-              placeholder={isBasic ? 'Договоренность об интерпретации' : 'Пояснение разработчика'}
-              value={convention}
-              disabled={disabled || (isBasic && state?.is_inherited)}
-              onChange={event => setConvention(event.target.value)}
-            />
-          </AnimateFade>
-          <AnimateFade key='cst_convention_button' hideContent={showConvention || (disabled && !processing)}>
-            <button
-              key='cst_disable_comment'
-              id='cst_disable_comment'
-              type='button'
-              tabIndex={-1}
-              className='self-start cc-label clr-text-url hover:underline'
-              onClick={() => setForceComment(true)}
-            >
-              Добавить комментарий
-            </button>
-          </AnimateFade>
-
-          {!disabled || processing ? (
-            <div className='self-center flex'>
-              <SubmitButton
-                key='cst_form_submit'
-                id='cst_form_submit'
-                text='Сохранить изменения'
-                disabled={disabled || !isModified}
-                icon={<IconSave size='1.25rem' />}
+        {state ? (
+          <AnimatePresence>
+            <AnimateFade key='cst_expression_fade' hideContent={!state.definition_formal && isElementary}>
+              <EditorRSExpression
+                id='cst_expression'
+                label={
+                  state.cst_type === CstType.STRUCTURED
+                    ? 'Область определения'
+                    : isFunctional(state.cst_type)
+                    ? 'Определение функции'
+                    : 'Формальное определение'
+                }
+                placeholder={
+                  state.cst_type !== CstType.STRUCTURED
+                    ? 'Родоструктурное выражение'
+                    : 'Определение множества, которому принадлежат элементы родовой структуры'
+                }
+                value={expression}
+                activeCst={state}
+                disabled={disabled || state.is_inherited}
+                toggleReset={toggleReset}
+                onChange={newValue => setExpression(newValue)}
+                setTypification={setTypification}
+                onOpenEdit={onOpenEdit}
               />
-              <Overlay position='top-[0.1rem] left-[0.4rem]' className='cc-icons'>
-                {state?.is_inherited_parent ? (
-                  <MiniButton
-                    icon={<IconPredecessor size='1.25rem' className='clr-text-red' />}
-                    disabled
-                    titleHtml='Внимание!</br> Конституента имеет потомков<br/> в операционной схеме синтеза'
-                  />
-                ) : null}
-                {state?.is_inherited ? (
-                  <MiniButton
-                    icon={<IconChild size='1.25rem' className='clr-text-red' />}
-                    disabled
-                    titleHtml='Внимание!</br> Конституента является наследником<br/>'
-                  />
-                ) : null}
-              </Overlay>
-            </div>
-          ) : null}
-        </AnimatePresence>
+            </AnimateFade>
+            <AnimateFade key='cst_definition_fade' hideContent={!state.definition_raw && isElementary}>
+              <RefsInput
+                id='cst_definition'
+                label='Текстовое определение'
+                placeholder='Текстовая интерпретация формального выражения'
+                minHeight='3.75rem'
+                maxHeight='8rem'
+                schema={schema}
+                onOpenEdit={onOpenEdit}
+                value={textDefinition}
+                initialValue={state.definition_raw}
+                resolved={state.definition_resolved}
+                disabled={disabled}
+                onChange={newValue => setTextDefinition(newValue)}
+              />
+            </AnimateFade>
+            <AnimateFade key='cst_convention_fade' hideContent={!showConvention}>
+              <TextArea
+                id='cst_convention'
+                fitContent
+                className='max-h-[8rem]'
+                spellCheck
+                label={isBasic ? 'Конвенция' : 'Комментарий'}
+                placeholder={isBasic ? 'Договоренность об интерпретации' : 'Пояснение разработчика'}
+                value={convention}
+                disabled={disabled || (isBasic && state.is_inherited)}
+                onChange={event => setConvention(event.target.value)}
+              />
+            </AnimateFade>
+            <AnimateFade key='cst_convention_button' hideContent={showConvention || (disabled && !processing)}>
+              <button
+                key='cst_disable_comment'
+                id='cst_disable_comment'
+                type='button'
+                tabIndex={-1}
+                className='self-start cc-label clr-text-url hover:underline'
+                onClick={() => setForceComment(true)}
+              >
+                Добавить комментарий
+              </button>
+            </AnimateFade>
+
+            {!disabled || processing ? (
+              <div className='self-center flex'>
+                <SubmitButton
+                  key='cst_form_submit'
+                  id='cst_form_submit'
+                  text='Сохранить изменения'
+                  disabled={disabled || !isModified}
+                  icon={<IconSave size='1.25rem' />}
+                />
+                <Overlay position='top-[0.1rem] left-[0.4rem]' className='cc-icons'>
+                  {state.is_inherited_parent ? (
+                    <MiniButton
+                      icon={<IconPredecessor size='1.25rem' className='clr-text-red' />}
+                      disabled
+                      titleHtml='Внимание!</br> Конституента имеет потомков<br/> в операционной схеме синтеза'
+                    />
+                  ) : null}
+                  {state.is_inherited ? (
+                    <MiniButton
+                      icon={<IconChild size='1.25rem' className='clr-text-red' />}
+                      disabled
+                      titleHtml='Внимание!</br> Конституента является наследником<br/>'
+                    />
+                  ) : null}
+                </Overlay>
+              </div>
+            ) : null}
+          </AnimatePresence>
+        ) : null}
       </form>
     </AnimateFade>
   );
diff --git a/rsconcept/frontend/src/pages/RSFormPage/EditorRSExpression/EditorRSExpression.tsx b/rsconcept/frontend/src/pages/RSFormPage/EditorRSExpression/EditorRSExpression.tsx
index afcc6706..66d828c0 100644
--- a/rsconcept/frontend/src/pages/RSFormPage/EditorRSExpression/EditorRSExpression.tsx
+++ b/rsconcept/frontend/src/pages/RSFormPage/EditorRSExpression/EditorRSExpression.tsx
@@ -28,7 +28,7 @@ import ToolbarRSExpression from './ToolbarRSExpression';
 
 interface EditorRSExpressionProps {
   id?: string;
-  activeCst?: IConstituenta;
+  activeCst: IConstituenta;
   value: string;
   label: string;
   placeholder?: string;
@@ -70,13 +70,10 @@ function EditorRSExpression({
 
   function handleChange(newValue: string) {
     onChange(newValue);
-    setIsModified(newValue !== activeCst?.definition_formal);
+    setIsModified(newValue !== activeCst.definition_formal);
   }
 
   function handleCheckExpression(callback?: (parse: IExpressionParse) => void) {
-    if (!activeCst) {
-      return;
-    }
     const prefix = getDefinitionPrefix(activeCst);
     const expression = prefix + value;
     parser.checkExpression(expression, activeCst, parse => {
@@ -99,7 +96,7 @@ function EditorRSExpression({
 
   const onShowError = useCallback(
     (error: IRSErrorDescription) => {
-      if (!activeCst || !rsInput.current) {
+      if (!rsInput.current) {
         return;
       }
       const prefix = getDefinitionPrefix(activeCst);
@@ -136,7 +133,7 @@ function EditorRSExpression({
         toast.error(errors.astFailed);
       } else {
         setSyntaxTree(parse.ast);
-        setExpression(getDefinitionPrefix(activeCst!) + value);
+        setExpression(getDefinitionPrefix(activeCst) + value);
         setShowAST(true);
       }
     });
@@ -145,7 +142,7 @@ function EditorRSExpression({
   const controls = useMemo(
     () => (
       <RSEditorControls
-        isOpen={showControls && (!disabled || (model.processing && !activeCst?.is_inherited))}
+        isOpen={showControls && (!disabled || (model.processing && !activeCst.is_inherited))}
         disabled={disabled}
         onEdit={handleEdit}
       />
@@ -172,7 +169,7 @@ function EditorRSExpression({
         <StatusBar
           processing={parser.processing}
           isModified={isModified}
-          constituenta={activeCst}
+          activeCst={activeCst}
           parseData={parser.parseData}
           onAnalyze={() => handleCheckExpression()}
         />
diff --git a/rsconcept/frontend/src/pages/RSFormPage/EditorRSExpression/StatusBar.tsx b/rsconcept/frontend/src/pages/RSFormPage/EditorRSExpression/StatusBar.tsx
index c46d1345..4bbacfcb 100644
--- a/rsconcept/frontend/src/pages/RSFormPage/EditorRSExpression/StatusBar.tsx
+++ b/rsconcept/frontend/src/pages/RSFormPage/EditorRSExpression/StatusBar.tsx
@@ -19,11 +19,11 @@ interface StatusBarProps {
   processing?: boolean;
   isModified?: boolean;
   parseData?: IExpressionParse;
-  constituenta?: IConstituenta;
+  activeCst: IConstituenta;
   onAnalyze: () => void;
 }
 
-function StatusBar({ isModified, processing, constituenta, parseData, onAnalyze }: StatusBarProps) {
+function StatusBar({ isModified, processing, activeCst, parseData, onAnalyze }: StatusBarProps) {
   const { colors } = useConceptOptions();
   const status = useMemo(() => {
     if (isModified) {
@@ -33,8 +33,8 @@ function StatusBar({ isModified, processing, constituenta, parseData, onAnalyze
       const parse = parseData.parseResult ? ParsingStatus.VERIFIED : ParsingStatus.INCORRECT;
       return inferStatus(parse, parseData.valueClass);
     }
-    return inferStatus(constituenta?.parse?.status, constituenta?.parse?.valueClass);
-  }, [isModified, constituenta, parseData]);
+    return inferStatus(activeCst.parse.status, activeCst.parse.valueClass);
+  }, [isModified, activeCst, parseData]);
 
   return (
     <div