ConceptProd/ConceptPortal-public
1
0
Fork 0
mirror of https://github.com/IRBorisov/ConceptPortal.git synced 2025-06-26 04:50:36 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

R: Remove redundant useEffects
Some checks failed
Frontend CI / build (22.x) (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Ivan 2025-02-15 18:33:05 +03:00
parent 35256d570f
commit 440a655395
4 changed files with 14 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rsconcept/frontend/src/features/home/DatabaseSchemaPage.tsx
View File

@ -1,6 +1,6 @@
'use client';
import { useEffect } from 'react';
import { useLayoutEffect } from 'react';
import { TransformComponent, TransformWrapper } from 'react-zoom-pan-pinch';
import { useAppLayoutStore, useFitHeight } from '@/stores/appLayout';
@ -10,7 +10,7 @@ export function Component() {
const hideFooter = useAppLayoutStore(state => state.hideFooter);
const panelHeight = useFitHeight('0px');
useEffect(() => {
useLayoutEffect(() => {
hideFooter(true);
return () => hideFooter(false);
}, [hideFooter]);

23
rsconcept/frontend/src/features/home/HomePage.tsx
View File

@ -1,28 +1,17 @@
import { useEffect } from 'react';
import { urls, useConceptNavigation } from '@/app';
import { useAuthSuspense } from '@/features/auth';
import { Loader } from '@/components/Loader';
import { PARAMETER } from '@/utils/constants';
function HomePage() {
const router = useConceptNavigation();
const { isAnonymous } = useAuthSuspense();
useEffect(() => {
if (isAnonymous) {
setTimeout(() => {
router.replace(urls.manuals);
}, PARAMETER.refreshTimeout);
} else {
setTimeout(() => {
router.replace(urls.library);
}, PARAMETER.refreshTimeout);
}
}, [router, isAnonymous]);
if (isAnonymous) {
router.replace(urls.manuals);
} else {
router.replace(urls.library);
}
return <Loader />;
return null;
}
export default HomePage;

6
rsconcept/frontend/src/features/oss/pages/OssPage/OssTabs.tsx
View File

@ -1,6 +1,6 @@
'use client';
import { useEffect } from 'react';
import { useLayoutEffect } from 'react';
import clsx from 'clsx';
import { useConceptNavigation } from '@/app/Navigation/NavigationContext';
@ -24,7 +24,7 @@ function OssTabs({ activeTab }: OssTabsProps) {
const hideFooter = useAppLayoutStore(state => state.hideFooter);
useEffect(() => {
useLayoutEffect(() => {
const oldTitle = document.title;
document.title = schema.title;
return () => {
@ -32,7 +32,7 @@ function OssTabs({ activeTab }: OssTabsProps) {
};
}, [schema.title]);
useEffect(() => {
useLayoutEffect(() => {
hideFooter(activeTab === OssTabID.GRAPH);
}, [activeTab, hideFooter]);

6
rsconcept/frontend/src/features/rsform/pages/RSFormPage/RSTabs.tsx
View File

@ -1,6 +1,6 @@
'use client';
import { useEffect } from 'react';
import { useLayoutEffect } from 'react';
import clsx from 'clsx';
import { useConceptNavigation } from '@/app/Navigation/NavigationContext';
@ -31,7 +31,7 @@ function RSTabs({ activeID, activeTab }: RSTabsProps) {
const { setIsModified } = useModificationStore();
const { schema, selected, setSelected, navigateRSForm } = useRSEdit();
useEffect(() => {
useLayoutEffect(() => {
const oldTitle = document.title;
document.title = schema.title;
return () => {
@ -39,7 +39,7 @@ function RSTabs({ activeID, activeTab }: RSTabsProps) {
};
}, [schema.title]);
useEffect(() => {
useLayoutEffect(() => {
hideFooter(activeTab !== RSTabID.CARD);
setIsModified(false);
if (activeTab === RSTabID.CST_EDIT) {