From 35754a59c718bf9417f53adf8177943e30e1c816 Mon Sep 17 00:00:00 2001 From: IRBorisov <8611739+IRBorisov@users.noreply.github.com> Date: Sun, 27 Aug 2023 16:35:17 +0300 Subject: [PATCH] Minor UI fixes --- .../frontend/src/components/Common/Dropdown.tsx | 4 ++-- .../src/components/Navigation/Navigation.tsx | 4 ++-- .../src/components/Navigation/UserDropdown.tsx | 14 ++++++++++---- .../src/components/Navigation/UserMenu.tsx | 2 +- rsconcept/frontend/src/context/RSFormContext.tsx | 6 +++--- .../frontend/src/hooks/useCheckExpression.ts | 2 +- rsconcept/frontend/src/hooks/useDropdown.ts | 6 +++--- rsconcept/frontend/src/hooks/useRSFormDetails.ts | 5 ++++- rsconcept/frontend/src/hooks/useResolveText.ts | 4 ++-- .../src/pages/LibraryPage/PickerStrategy.tsx | 6 ++++++ rsconcept/frontend/src/pages/LoginPage.tsx | 6 +++--- .../src/pages/RSFormPage/DlgCloneRSForm.tsx | 8 ++++---- .../src/pages/RSFormPage/DlgCreateCst.tsx | 15 +++++---------- .../src/pages/RSFormPage/DlgRenameCst.tsx | 12 ++++++------ .../src/pages/RSFormPage/DlgUploadRSForm.tsx | 4 ++-- .../src/pages/RSFormPage/EditorConstituenta.tsx | 16 +++++++++------- .../src/pages/RSFormPage/EditorItems.tsx | 9 ++++++--- .../src/pages/RSFormPage/EditorTermGraph.tsx | 4 ++-- .../frontend/src/pages/RSFormPage/RSTabs.tsx | 4 +++- .../pages/RSFormPage/elements/RSLocalButton.tsx | 2 +- .../pages/RSFormPage/elements/RSTokenButton.tsx | 2 +- rsconcept/frontend/src/pages/RegisterPage.tsx | 12 ++++++------ 22 files changed, 82 insertions(+), 65 deletions(-) diff --git a/rsconcept/frontend/src/components/Common/Dropdown.tsx b/rsconcept/frontend/src/components/Common/Dropdown.tsx index 0f1f39b0..af7b538c 100644 --- a/rsconcept/frontend/src/components/Common/Dropdown.tsx +++ b/rsconcept/frontend/src/components/Common/Dropdown.tsx @@ -6,8 +6,8 @@ interface DropdownProps { function Dropdown({ children, widthClass = 'w-fit', stretchLeft }: DropdownProps) { return ( -
-
+
+
{children}
diff --git a/rsconcept/frontend/src/components/Navigation/Navigation.tsx b/rsconcept/frontend/src/components/Navigation/Navigation.tsx index 51efca02..fbf2c8a7 100644 --- a/rsconcept/frontend/src/components/Navigation/Navigation.tsx +++ b/rsconcept/frontend/src/components/Navigation/Navigation.tsx @@ -10,8 +10,8 @@ function Navigation () { const navigate = useNavigate(); const { noNavigation, toggleNoNavigation } = useConceptTheme(); - const navigateLibrary = () => { navigate('/library') }; - const navigateHelp = () => { navigate('/manuals') }; + const navigateLibrary = () => navigate('/library'); + const navigateHelp = () => navigate('/manuals'); return (
{ user && menu.isActive && { menu.hide(); }} + hideDropdown={() => menu.hide()} />}
); diff --git a/rsconcept/frontend/src/context/RSFormContext.tsx b/rsconcept/frontend/src/context/RSFormContext.tsx index a5d22ce6..990a3305 100644 --- a/rsconcept/frontend/src/context/RSFormContext.tsx +++ b/rsconcept/frontend/src/context/RSFormContext.tsx @@ -283,9 +283,9 @@ export const RSFormState = ({ schemaID, children }: RSFormStateProps) => { showError: true, setLoading: setProcessing, onError: error => setError(error), - onSuccess: newData => { - reload(setProcessing, () => { if (callback) callback(newData); }) - } + onSuccess: newData => reload(setProcessing, () => { + if (callback) callback(newData); + }) }); }, [setError, reload]); diff --git a/rsconcept/frontend/src/hooks/useCheckExpression.ts b/rsconcept/frontend/src/hooks/useCheckExpression.ts index a1ad5572..fcb7ba57 100644 --- a/rsconcept/frontend/src/hooks/useCheckExpression.ts +++ b/rsconcept/frontend/src/hooks/useCheckExpression.ts @@ -60,7 +60,7 @@ function useCheckExpression({ schema }: { schema?: IRSForm }) { const [error, setError] = useState(undefined); const [parseData, setParseData] = useState(undefined); - const resetParse = useCallback(() => { setParseData(undefined); }, []); + const resetParse = useCallback(() => setParseData(undefined), []); function checkExpression(expression: string, activeCst?: IConstituenta, onSuccess?: DataCallback) { setError(undefined); diff --git a/rsconcept/frontend/src/hooks/useDropdown.ts b/rsconcept/frontend/src/hooks/useDropdown.ts index ef95f9eb..db18cfe6 100644 --- a/rsconcept/frontend/src/hooks/useDropdown.ts +++ b/rsconcept/frontend/src/hooks/useDropdown.ts @@ -6,14 +6,14 @@ function useDropdown() { const [isActive, setIsActive] = useState(false); const ref = useRef(null); - useClickedOutside({ ref, callback: () => { setIsActive(false); } }) + useClickedOutside({ ref, callback: () => setIsActive(false) }) return { ref, isActive, setIsActive, - toggle: () => { setIsActive(!isActive); }, - hide: () => { setIsActive(false); } + toggle: () => setIsActive(!isActive), + hide: () => setIsActive(false) }; } diff --git a/rsconcept/frontend/src/hooks/useRSFormDetails.ts b/rsconcept/frontend/src/hooks/useRSFormDetails.ts index 1fbf7b48..9b5e1d50 100644 --- a/rsconcept/frontend/src/hooks/useRSFormDetails.ts +++ b/rsconcept/frontend/src/hooks/useRSFormDetails.ts @@ -27,7 +27,10 @@ export function useRSFormDetails({ target }: { target?: string }) { getRSFormDetails(target, { showError: true, setLoading: setCustomLoading ?? setLoading, - onError: error => { setInnerSchema(undefined); setError(error); }, + onError: error => { + setInnerSchema(undefined); + setError(error); + }, onSuccess: schema => { setSchema(schema); if (callback) callback(); diff --git a/rsconcept/frontend/src/hooks/useResolveText.ts b/rsconcept/frontend/src/hooks/useResolveText.ts index 8816073d..90d38c86 100644 --- a/rsconcept/frontend/src/hooks/useResolveText.ts +++ b/rsconcept/frontend/src/hooks/useResolveText.ts @@ -9,7 +9,7 @@ function useResolveText({ schema }: { schema?: IRSForm }) { const [error, setError] = useState(undefined); const [refsData, setRefsData] = useState(undefined); - const resetData = useCallback(() => { setRefsData(undefined); }, []); + const resetData = useCallback(() => setRefsData(undefined), []); function resolveText(text: string, onSuccess?: DataCallback) { setError(undefined); @@ -17,7 +17,7 @@ function useResolveText({ schema }: { schema?: IRSForm }) { data: { text: text }, showError: true, setLoading, - onError: error => { setError(error); }, + onError: error => setError(error), onSuccess: data => { setRefsData(data); if (onSuccess) onSuccess(data); diff --git a/rsconcept/frontend/src/pages/LibraryPage/PickerStrategy.tsx b/rsconcept/frontend/src/pages/LibraryPage/PickerStrategy.tsx index b3238fd0..f0de720d 100644 --- a/rsconcept/frontend/src/pages/LibraryPage/PickerStrategy.tsx +++ b/rsconcept/frontend/src/pages/LibraryPage/PickerStrategy.tsx @@ -38,12 +38,14 @@ function PickerStrategy({ value, onChange }: PickerStrategyProps) { handleChange(LibraryFilterStrategy.COMMON)}> @@ -51,6 +53,7 @@ function PickerStrategy({ value, onChange }: PickerStrategyProps) { @@ -58,6 +61,7 @@ function PickerStrategy({ value, onChange }: PickerStrategyProps) { @@ -65,6 +69,7 @@ function PickerStrategy({ value, onChange }: PickerStrategyProps) { @@ -72,6 +77,7 @@ function PickerStrategy({ value, onChange }: PickerStrategyProps) { diff --git a/rsconcept/frontend/src/pages/LoginPage.tsx b/rsconcept/frontend/src/pages/LoginPage.tsx index 433a75c3..303f62ad 100644 --- a/rsconcept/frontend/src/pages/LoginPage.tsx +++ b/rsconcept/frontend/src/pages/LoginPage.tsx @@ -34,7 +34,7 @@ function LoginPage() { username: username, password: password }; - login(data, () => { navigate('/library?filter=personal'); }); + login(data, () => navigate('/library')); } } @@ -54,14 +54,14 @@ function LoginPage() { type='text' value={username} autoFocus - onChange={event => { setUsername(event.target.value); }} + onChange={event => setUsername(event.target.value)} /> { setPassword(event.target.value); }} + onChange={event => setPassword(event.target.value)} />
diff --git a/rsconcept/frontend/src/pages/RSFormPage/DlgCloneRSForm.tsx b/rsconcept/frontend/src/pages/RSFormPage/DlgCloneRSForm.tsx index 5edb0b4e..0e614216 100644 --- a/rsconcept/frontend/src/pages/RSFormPage/DlgCloneRSForm.tsx +++ b/rsconcept/frontend/src/pages/RSFormPage/DlgCloneRSForm.tsx @@ -65,21 +65,21 @@ function DlgCloneRSForm({ hideWindow }: DlgCloneRSFormProps) { { setTitle(event.target.value); }} + onChange={event => setTitle(event.target.value)} /> { setAlias(event.target.value); }} + onChange={event => setAlias(event.target.value)} />